feat(formplayer): Add support for audio, video, select_file, improved photo handling#627
Merged
r0ssing merged 10 commits intoOpenDataEnsemble:devfrom May 4, 2026
Merged
Conversation
…mproved attachment handling - Added methods in WebViewMock to manage attachment display URLs and resolve them based on basenames. - Updated PhotoQuestionRenderer to utilize the new attachment handling logic, ensuring only basenames are persisted and displayed. - Removed deprecated webviewSafeImageSrc function to streamline image URL handling. - Adjusted CameraResultData interface to clarify persistence guidelines for attachment fields.
…istency - Changed all references from `build:rn` to `build:copy` to reflect the new build process that consolidates building and copying assets for both Formulus and ODE Desktop. - Updated documentation across multiple files to ensure clarity on the new build commands and their purposes. - Adjusted error messages in the code to align with the updated build command terminology.
- Updated triggers for pull requests and pushes to include additional relevant paths. - Added new jobs for building embedded formplayer assets and packaging desktop bundles. - Improved path filters and concurrency settings in the workflow configuration. - Clarified documentation regarding the build process and CI artifacts.
najuna-brian
previously approved these changes
May 4, 2026
Contributor
najuna-brian
left a comment
najuna-brian
left a comment
There was a problem hiding this comment.
Thank you @r0ssing
A lot can be done from ODE Desktop now
I like the new renders too 😃
- Added xdg-utils to the list of dependencies in the ode-desktop workflow to ensure proper functionality during builds.
Mishael-2584
approved these changes
May 4, 2026
Contributor
Mishael-2584
left a comment
Mishael-2584
left a comment
There was a problem hiding this comment.
I love it. Thanks for the update and support for these.
najuna-brian
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Title
This PR adds the missing implementation for audio/video/select_file question renderers as well as improves the photo question (fixes issue with thumbnail not showing).
It also adds storybook stories for each of the new question types in the formplayer (to be used in documentation/testing) as well as implementing parity across the bridge in stodybook, ODE Dekstop, and Formulus.
It also updates the ci/cd for ODE Desktop to have it be part of the formal GH actions build.
Finally it cleans up the build scripts to simply use "npm run build:copy" to have the dist copied to both desktop and formulus in one go.
Type of Change
Component(s) Affected
Thank you for contributing to Open Data Ensemble (ODE)!